[Tapioca Add-on] Trigger DSL generation upon file changes #2031
Conversation
KaanOzkan
force-pushed
the
ko/addon-watched-files
branch
from
9b590a0
to
eef6cb2
Compare
lib/ruby_lsp/tapioca/addon.rb
Outdated
| constants = changes.filter_map do |change| | ||
| path = change[:uri].gsub("file://", "") | ||
|
|
||
| entries = T.must(@index).entries_for(path, RubyIndexer::Entry::Class, RubyIndexer::Entry::Module) |
There was a problem hiding this comment.
Using grep, getting subclasses and then filtering them out feels weird to me. Wdyt of an API like this where you have a rest arg and use == instead? Or making the second argument optional and returning all entries by default?
There was a problem hiding this comment.
You can just use the parent class to filter both at the same time.
| entries = T.must(@index).entries_for(path, RubyIndexer::Entry::Class, RubyIndexer::Entry::Module) | |
| entries = T.must(@index).entries_for(path, RubyIndexer::Entry::Namespace) |
There was a problem hiding this comment.
I can't only use the parent class because it includes singleton classes. So I'm trying to avoid this filtering with a different API in Ruby LSP main...andyw8/tapioca-lsp#diff-8243d0258619c7955b4277251f121d4b6788da80bcae39fe5130f27019d143bbR64
There was a problem hiding this comment.
I think for our use case being able to omit the types and do our own filtering in tapioca makes sense. Will you accept that change in Ruby LSP?
There was a problem hiding this comment.
I mean, we created that API for the Tapioca add-on, so we can change it to whatever makes sense.
KaanOzkan
requested review from
Morriar,
amomchilov,
andyw8,
alexcrocha and
vinistock
and removed request for
a team,
Morriar and
amomchilov
lib/ruby_lsp/tapioca/addon.rb
Outdated
| constants = changes.filter_map do |change| | ||
| path = change[:uri].gsub("file://", "") | ||
|
|
||
| entries = T.must(@index).entries_for(path, RubyIndexer::Entry::Class, RubyIndexer::Entry::Module) |
There was a problem hiding this comment.
You can just use the parent class to filter both at the same time.
| entries = T.must(@index).entries_for(path, RubyIndexer::Entry::Class, RubyIndexer::Entry::Module) | |
| entries = T.must(@index).entries_for(path, RubyIndexer::Entry::Namespace) |
KaanOzkan
force-pushed
the
ko/addon-watched-files
branch
3 times, most recently
from
dfa196d
to
479d175
Compare
KaanOzkan
force-pushed
the
ko/addon-watched-files
branch
from
479d175
to
964ca6b
Compare
KaanOzkan
merged commit b6aac6a
into
tapioca-addon-feature-branch
|
We need to also update the # We need to change this to >= 0.3.18
addon = T.cast(::RubyLsp::Addon.get("Ruby LSP Rails", ">= 0.3.17", "< 0.4"), ::RubyLsp::Rails::Addon) |
Motivation
Merge part of tapioca add-on logic
Implementation
workspace_did_change_watched_filesmethod that uses the Ruby LSP index to find potentially modified constants in a file and sends them to the Rails appTests
We'll add tests when we can test rails client